From: Markus Elfring Date: Tue, 19 Jul 2016 19:24:26 +0000 (-0300) Subject: [media] tw686x: Delete an unnecessary check before the function call "video_unregiste... X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=c6e4b8c1d3a81a2611e0a045f1c1e34ad3fb092e;p=openwrt%2Fstaging%2Fblogic.git [media] tw686x: Delete an unnecessary check before the function call "video_unregister_device" The video_unregister_device() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/pci/tw686x/tw686x-video.c b/drivers/media/pci/tw686x/tw686x-video.c index be257d0257a6..24a813256c99 100644 --- a/drivers/media/pci/tw686x/tw686x-video.c +++ b/drivers/media/pci/tw686x/tw686x-video.c @@ -1120,8 +1120,7 @@ void tw686x_video_free(struct tw686x_dev *dev) for (ch = 0; ch < max_channels(dev); ch++) { struct tw686x_video_channel *vc = &dev->video_channels[ch]; - if (vc->device) - video_unregister_device(vc->device); + video_unregister_device(vc->device); if (dev->dma_ops->free) for (pb = 0; pb < 2; pb++)