From: Wei Yongjun Date: Fri, 30 Mar 2018 02:24:28 +0000 (+0000) Subject: net: hns3: remove unnecessary pci_set_drvdata() and devm_kfree() X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=c679f6a26dc3d450b76e94717850a14ff706cc58;p=openwrt%2Fstaging%2Fblogic.git net: hns3: remove unnecessary pci_set_drvdata() and devm_kfree() There is no need for explicit calls of devm_kfree(), as the allocated memory will be freed during driver's detach. The driver core clears the driver data to NULL after device_release. Thus, it is not needed to manually clear the device driver data to NULL. So remove the unnecessary pci_set_drvdata() and devm_kfree(). Signed-off-by: Wei Yongjun Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c index a31b4adf6e6a..8c55965a66ac 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -1614,10 +1614,6 @@ static void hns3_remove(struct pci_dev *pdev) struct hnae3_ae_dev *ae_dev = pci_get_drvdata(pdev); hnae3_unregister_ae_dev(ae_dev); - - devm_kfree(&pdev->dev, ae_dev); - - pci_set_drvdata(pdev, NULL); } static struct pci_driver hns3_driver = {