From: Petr Štetiar <ynezz@true.cz>
Date: Thu, 19 Dec 2019 09:48:57 +0000 (+0100)
Subject: ubus_monitor: workaround possibly false positive uses of memory after it is freed
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=c60583743ccf105f5d70270b437d2f7636d21193;p=project%2Fubus.git

ubus_monitor: workaround possibly false positive uses of memory after it is freed

scan-build from clang-9 has reported following:

 libubox/list.h:141:2: warning: Use of memory after it is freed
        _list_add(_new, head, head->next);

Signed-off-by: Petr Štetiar <ynezz@true.cz>
---

diff --git a/ubusd_monitor.c b/ubusd_monitor.c
index 501e06d..bba741e 100644
--- a/ubusd_monitor.c
+++ b/ubusd_monitor.c
@@ -41,7 +41,7 @@ ubusd_monitor_connect(struct ubus_client *cl, struct ubus_msg_buf *ub)
 		return false;
 
 	m->cl = cl;
-	list_add(&m->list, &monitors);
+	list_add_tail(&m->list, &monitors);
 
 	return true;
 }