From: Colin Ian King Date: Mon, 2 Jul 2018 13:27:35 +0000 (+0100) Subject: staging: rts5208: fix missing error check on call to rtsx_write_register X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=c5fae4f4fd28189b1062fb8ef7b21fec37cb8b17;p=openwrt%2Fstaging%2Fblogic.git staging: rts5208: fix missing error check on call to rtsx_write_register Currently the check on error return from the call to rtsx_write_register is checking the error status from the previous call. Fix this by adding in the missing assignment of retval. Detected by CoverityScan, CID#709877 Fixes: fa590c222fba ("staging: rts5208: add support for rts5208 and rts5288") Signed-off-by: Colin Ian King Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c index f2778abf10c0..e7efa34195c7 100644 --- a/drivers/staging/rts5208/sd.c +++ b/drivers/staging/rts5208/sd.c @@ -4690,7 +4690,7 @@ int sd_execute_write_data(struct scsi_cmnd *srb, struct rtsx_chip *chip) goto sd_execute_write_cmd_failed; } - rtsx_write_register(chip, SD_BYTE_CNT_L, 0xFF, 0x00); + retval = rtsx_write_register(chip, SD_BYTE_CNT_L, 0xFF, 0x00); if (retval != STATUS_SUCCESS) { goto sd_execute_write_cmd_failed; }