From: Jia-Ju Bai Date: Sat, 4 Aug 2018 00:25:35 +0000 (+0800) Subject: gpu: drm: radeon: cik: Replace mdelay() with msleep() in cik_pcie_gen3_enable() X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=c51cebb890dc76260c02354882cf333c8207dd19;p=openwrt%2Fstaging%2Fblogic.git gpu: drm: radeon: cik: Replace mdelay() with msleep() in cik_pcie_gen3_enable() cik_pcie_gen3_enable() is never called in atomic context. It calls mdelay() to busily wait, which is not necessary. mdelay() can be replaced with msleep(). This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c index ebce4601a305..ab7b4e2ffcd2 100644 --- a/drivers/gpu/drm/radeon/cik.c +++ b/drivers/gpu/drm/radeon/cik.c @@ -9600,7 +9600,7 @@ static void cik_pcie_gen3_enable(struct radeon_device *rdev) tmp |= LC_REDO_EQ; WREG32_PCIE_PORT(PCIE_LC_CNTL4, tmp); - mdelay(100); + msleep(100); /* linkctl */ pci_read_config_word(root, bridge_pos + PCI_EXP_LNKCTL, &tmp16);