From: Andy Shevchenko Date: Thu, 25 Jul 2019 19:05:50 +0000 (+0300) Subject: platform/x86: i2c-multi-instantiate: Use struct_size() helper X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=c03f282e506f1e873ef9b270cf245509d68dd53b;p=openwrt%2Fstaging%2Fblogic.git platform/x86: i2c-multi-instantiate: Use struct_size() helper One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. Signed-off-by: Andy Shevchenko Reviewed-by: Hans de Goede --- diff --git a/drivers/platform/x86/i2c-multi-instantiate.c b/drivers/platform/x86/i2c-multi-instantiate.c index 197d8a192721..61fe341a85aa 100644 --- a/drivers/platform/x86/i2c-multi-instantiate.c +++ b/drivers/platform/x86/i2c-multi-instantiate.c @@ -81,9 +81,7 @@ static int i2c_multi_inst_probe(struct platform_device *pdev) if (ret < 0) return ret; - multi = devm_kmalloc(dev, - offsetof(struct i2c_multi_inst_data, clients[ret]), - GFP_KERNEL); + multi = devm_kmalloc(dev, struct_size(multi, clients, ret), GFP_KERNEL); if (!multi) return -ENOMEM;