From: Bjorn Helgaas Date: Fri, 16 Dec 2011 12:31:54 +0000 (+0000) Subject: de4x5/PCI: use list_for_each_entry() for bus->devices traversal X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=bf684f6512223673aa78b62ea59df8be409c460d;p=openwrt%2Fstaging%2Fblogic.git de4x5/PCI: use list_for_each_entry() for bus->devices traversal Replace open-coded list traversal with list_for_each_entry(). CC: Grant Grundler CC: netdev@vger.kernel.org Signed-off-by: Bjorn Helgaas Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/dec/tulip/de4x5.c b/drivers/net/ethernet/dec/tulip/de4x5.c index 871bcaa7068d..3f5d3b964c28 100644 --- a/drivers/net/ethernet/dec/tulip/de4x5.c +++ b/drivers/net/ethernet/dec/tulip/de4x5.c @@ -2127,14 +2127,9 @@ srom_search(struct net_device *dev, struct pci_dev *pdev) u_long iobase = 0; /* Clear upper 32 bits in Alphas */ int i, j; struct de4x5_private *lp = netdev_priv(dev); - struct list_head *walk; - - list_for_each(walk, &pdev->bus_list) { - struct pci_dev *this_dev = pci_dev_b(walk); - - /* Skip the pci_bus list entry */ - if (list_entry(walk, struct pci_bus, devices) == pdev->bus) continue; + struct pci_dev *this_dev; + list_for_each_entry(this_dev, &pdev->bus->devices, bus_list) { vendor = this_dev->vendor; device = this_dev->device << 8; if (!(is_DC21040 || is_DC21041 || is_DC21140 || is_DC2114x)) continue;