From: Hauke Mehrtens <hauke@hauke-m.de>
Date: Wed, 19 Sep 2012 10:57:38 +0000 (+0000)
Subject: switch: improve error message
X-Git-Tag: v19.07.0-rc1~23515
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=bf0974e8dad414249d7cc44b7acc665658ca634a;p=openwrt%2Fstaging%2Fhauke.git

switch: improve error message

SVN-Revision: 33464
---

diff --git a/package/switch/src/switch-robo.c b/package/switch/src/switch-robo.c
index 656e69ff12..5b849cb33d 100644
--- a/package/switch/src/switch-robo.c
+++ b/package/switch/src/switch-robo.c
@@ -96,12 +96,15 @@ static int do_ioctl(int cmd)
 static u16 mdio_read(__u16 phy_id, __u8 reg)
 {
 	struct mii_ioctl_data *mii = if_mii(&robo.ifr);
+	int err;
+
 	mii->phy_id = phy_id;
 	mii->reg_num = reg;
 
-	if (do_ioctl(SIOCGMIIREG) < 0) {
+	err = do_ioctl(SIOCGMIIREG);
+	if (err < 0) {
 		printk(KERN_ERR PFX
-		       "[%s:%d] SIOCGMIIREG failed!\n", __FILE__, __LINE__);
+		       "[%s:%d] SIOCGMIIREG failed! err: %i\n", __FILE__, __LINE__, err);
 
 		return 0xffff;
 	}
@@ -112,14 +115,16 @@ static u16 mdio_read(__u16 phy_id, __u8 reg)
 static void mdio_write(__u16 phy_id, __u8 reg, __u16 val)
 {
 	struct mii_ioctl_data *mii = if_mii(&robo.ifr);
+	int err;
 
 	mii->phy_id = phy_id;
 	mii->reg_num = reg;
 	mii->val_in = val;
 
-	if (do_ioctl(SIOCSMIIREG) < 0) {
+	err = do_ioctl(SIOCSMIIREG);
+	if (err < 0) {
 		printk(KERN_ERR PFX
-		       "[%s:%d] SIOCSMIIREG failed!\n", __FILE__, __LINE__);
+		       "[%s:%d] SIOCSMIIREG failed! err: %i\n", __FILE__, __LINE__, err);
 		return;
 	}
 }