From: Cristian Sicilia Date: Mon, 12 Nov 2018 20:43:58 +0000 (+0100) Subject: staging: erofs: unzip_vle.c: Constant in comparison on right side X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=bc8098de78d19eafbc197c29e76d96eb9e831db8;p=openwrt%2Fstaging%2Fblogic.git staging: erofs: unzip_vle.c: Constant in comparison on right side Comparisons should place the constant on the right side of the test. Signed-off-by: Cristian Sicilia Reviewed-by: Gao Xiang Reviewed-by: Chao Yu Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/erofs/unzip_vle.c b/drivers/staging/erofs/unzip_vle.c index 1ffeeaa6e976..35add4eb3057 100644 --- a/drivers/staging/erofs/unzip_vle.c +++ b/drivers/staging/erofs/unzip_vle.c @@ -250,8 +250,8 @@ static inline bool try_to_claim_workgroup( retry: if (grp->next == Z_EROFS_VLE_WORKGRP_NIL) { /* type 1, nil workgroup */ - if (Z_EROFS_VLE_WORKGRP_NIL != cmpxchg(&grp->next, - Z_EROFS_VLE_WORKGRP_NIL, *owned_head)) + if (cmpxchg(&grp->next, Z_EROFS_VLE_WORKGRP_NIL, + *owned_head) != Z_EROFS_VLE_WORKGRP_NIL) goto retry; *owned_head = grp; @@ -262,8 +262,8 @@ retry: * be careful that its submission itself is governed * by the original owned chain. */ - if (Z_EROFS_VLE_WORKGRP_TAIL != cmpxchg(&grp->next, - Z_EROFS_VLE_WORKGRP_TAIL, *owned_head)) + if (cmpxchg(&grp->next, Z_EROFS_VLE_WORKGRP_TAIL, + *owned_head) != Z_EROFS_VLE_WORKGRP_TAIL) goto retry; *owned_head = Z_EROFS_VLE_WORKGRP_TAIL;