From: Rafał Miłecki <rafal@milecki.pl>
Date: Mon, 25 Oct 2021 08:17:15 +0000 (+0200)
Subject: layerscape: mkits-multiple-config: fail on invalid arguments
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=b8bbac951c42c6639a66696ade4477aa2be6aa54;p=openwrt%2Fstaging%2Fxback.git

layerscape: mkits-multiple-config: fail on invalid arguments

Fail if arguments couldn't be parsed and print unrecognized part. It's
important when running it from script with dynamic values. Missing value
could result in skipping argument and silent failures (unexpected its).

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---

diff --git a/target/linux/layerscape/image/mkits-multiple-config.sh b/target/linux/layerscape/image/mkits-multiple-config.sh
index 68870686c5..b2d8f4ef7f 100755
--- a/target/linux/layerscape/image/mkits-multiple-config.sh
+++ b/target/linux/layerscape/image/mkits-multiple-config.sh
@@ -198,6 +198,11 @@ parse_args() {
 			usage;;
 		esac
 	done
+	shift $(($OPTIND - 1))
+	[ $# -gt 0 ] && {
+		echo "Failed to parse all passed arguments (unrecognized: \"$@\")"
+		exit 1
+	}
 	[ -n "${OUTPUT}" ] || OUTPUT=fitimage.its
 	[ -n "${VERSION}" ] || VERSION="Unknown"
 	[ -n "${ARCH}" ] || ARCH=arm