From: Jo-Philipp Wich <jow@openwrt.org>
Date: Tue, 9 Feb 2016 07:53:28 +0000 (+0100)
Subject: kmodloader: fix open() error handling
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=b0d5399c3db83c2c8f9d8aae944f873343b3a038;p=project%2Fubox.git

kmodloader: fix open() error handling

Fixes kmodloader on systems without stdio and prevents fd leaks in case
descriptor zero is opened.

Signed-off-by: Jo-Philipp Wich <jow@openwrt.org>
---

diff --git a/kmodloader.c b/kmodloader.c
index 387678a..86e3f44 100644
--- a/kmodloader.c
+++ b/kmodloader.c
@@ -281,7 +281,7 @@ static struct module* get_module_info(const char *module, const char *name)
 	struct module *m;
 	struct stat s;
 
-	if (!fd) {
+	if (fd < 0) {
 		ULOG_ERR("failed to open %s\n", module);
 		return NULL;
 	}
@@ -381,7 +381,7 @@ static int print_modinfo(char *module)
 	struct stat s;
 	char *map, *strings;
 
-	if (!fd) {
+	if (fd < 0) {
 		ULOG_ERR("failed to open %s\n", module);
 		return -1;
 	}
@@ -466,7 +466,7 @@ static int insert_module(char *path, const char *options)
 	}
 
 	fd = open(path, O_RDONLY);
-	if (!fd) {
+	if (fd < 0) {
 		ULOG_ERR("cannot open %s\n", path);
 		return ret;
 	}