From: Jo-Philipp Wich <jo@mein.io>
Date: Thu, 23 Dec 2021 16:06:09 +0000 (+0100)
Subject: luci-base: form.js: do not execute embedded script code in stripTags()
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=ad33852de03b28865505ecdd30cdc8c24f24417c;p=project%2Fluci.git

luci-base: form.js: do not execute embedded script code in stripTags()

Instead of relying on .innerHTML which executes embedded script code to
parse a given HTML fragment, use dom.parse() which utilizies DOMParser()
internally in order to extract textContent in a safe manner.

Fixes: FS#4199
Ref: https://bugs.openwrt.org/index.php?do=details&task_id=4199
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 993151504e8e810c083d3257555bdcdc2f00673a)
---

diff --git a/modules/luci-base/htdocs/luci-static/resources/form.js b/modules/luci-base/htdocs/luci-static/resources/form.js
index 72b4173493..92c53253bb 100644
--- a/modules/luci-base/htdocs/luci-static/resources/form.js
+++ b/modules/luci-base/htdocs/luci-static/resources/form.js
@@ -279,7 +279,8 @@ var CBIAbstractElement = baseclass.extend(/** @lends LuCI.form.AbstractElement.p
 		if (typeof(s) == 'string' && !s.match(/[<>]/))
 			return s;
 
-		var x = E('div', {}, s);
+		var x = dom.parse('<div>' + s + '</div>');
+
 		return x.textContent || x.innerText || '';
 	},