From: Rui Salvaterra <rsalvaterra@gmail.com>
Date: Sun, 9 Jan 2022 23:27:28 +0000 (+0000)
Subject: procd: clean up /dev/pts mounts
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=ac2b8b365bdbcbf292f77409d180ec3c0963faf3;p=project%2Fprocd.git

procd: clean up /dev/pts mounts

The default mode is already 600, no need to specify it. Access times are also
irrelevant.

Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>
---

diff --git a/initd/early.c b/initd/early.c
index 87fee65..4b7e61c 100644
--- a/initd/early.c
+++ b/initd/early.c
@@ -64,7 +64,7 @@ early_mounts(void)
 		mount("tmpfs", "/dev", "tmpfs", MS_NOATIME | MS_NOEXEC | MS_NOSUID, "mode=0755,size=512K");
 		ignore(symlink("/tmp/shm", "/dev/shm"));
 		mkdir("/dev/pts", 0755);
-		mount("devpts", "/dev/pts", "devpts", MS_NOATIME | MS_NOEXEC | MS_NOSUID, "mode=600");
+		mount("devpts", "/dev/pts", "devpts", MS_NOATIME | MS_NOEXEC | MS_NOSUID, 0);
 
 		early_dev();
 	}
diff --git a/plug/coldplug.c b/plug/coldplug.c
index b9462e7..308b79d 100644
--- a/plug/coldplug.c
+++ b/plug/coldplug.c
@@ -50,7 +50,7 @@ void procd_coldplug(void)
 		umount2("/dev/", MNT_DETACH);
 		mount("tmpfs", "/dev", "tmpfs", MS_NOATIME | MS_NOEXEC | MS_NOSUID, "mode=0755,size=512K");
 		mkdir("/dev/pts", 0755);
-		mount("devpts", "/dev/pts", "devpts", MS_NOEXEC | MS_NOSUID, 0);
+		mount("devpts", "/dev/pts", "devpts", MS_NOATIME | MS_NOEXEC | MS_NOSUID, 0);
 	}
 
 	ignore(symlink("/tmp/shm", "/dev/shm"));