From: Vasanthakumar Thiagarajan Date: Mon, 26 Sep 2011 09:19:03 +0000 (+0530) Subject: ath6kl: Remove unnecessary retrieval of first list entry in ath6kl_htc_tx_setup_scat_... X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=aad9339fa2a5e5b51874cfec9883819f59090198;p=openwrt%2Fstaging%2Fblogic.git ath6kl: Remove unnecessary retrieval of first list entry in ath6kl_htc_tx_setup_scat_list() It is unnecessary to take the first list entry from queue again for transmission. Sometimes it may look racy when the head of the list changes between subsequent retrival, but should not happen in practical. Reported-by: Jouni Malinen Signed-off-by: Vasanthakumar Thiagarajan Signed-off-by: Kalle Valo --- diff --git a/drivers/net/wireless/ath/ath6kl/htc.c b/drivers/net/wireless/ath/ath6kl/htc.c index 9aa2e4447900..feed98535c9f 100644 --- a/drivers/net/wireless/ath/ath6kl/htc.c +++ b/drivers/net/wireless/ath/ath6kl/htc.c @@ -389,7 +389,6 @@ static int ath6kl_htc_tx_setup_scat_list(struct htc_target *target, rem_scat -= len; /* now remove it from the queue */ - packet = list_first_entry(queue, struct htc_packet, list); list_del(&packet->list); scat_req->scat_list[i].packet = packet;