From: Markus Elfring Date: Sat, 3 Jan 2015 16:06:04 +0000 (+0100) Subject: ALSA: emu10k1: Delete an unnecessary check before the function call "kfree" X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=a827977ac31cb5d1f4720efede9bbbf241789993;p=openwrt%2Fstaging%2Fblogic.git ALSA: emu10k1: Delete an unnecessary check before the function call "kfree" The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai --- diff --git a/sound/pci/emu10k1/p16v.c b/sound/pci/emu10k1/p16v.c index b672755815e1..3c60b433de9f 100644 --- a/sound/pci/emu10k1/p16v.c +++ b/sound/pci/emu10k1/p16v.c @@ -166,11 +166,8 @@ static struct snd_pcm_hardware snd_p16v_capture_hw = { static void snd_p16v_pcm_free_substream(struct snd_pcm_runtime *runtime) { struct snd_emu10k1_pcm *epcm = runtime->private_data; - - if (epcm) { - /* dev_dbg(emu->card->dev, "epcm free: %p\n", epcm); */ - kfree(epcm); - } + + kfree(epcm); } /* open_playback callback */