From: Ben Hutchings Date: Mon, 2 Jul 2012 20:36:59 +0000 (+0100) Subject: sfc: Use strlcpy() to copy ethtool stats names X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=a4ed2d4cd96dd71b0f2e04a88f83abcab6ddd023;p=openwrt%2Fstaging%2Fblogic.git sfc: Use strlcpy() to copy ethtool stats names Fix CID 113703 in the Coverity report on Linux. ethtool stats names are limited to 32 bytes including a null terminator. Use strlcpy() to ensure that we will always include the null terminator even if a source string becomes longer than this. Signed-off-by: Ben Hutchings --- diff --git a/drivers/net/ethernet/sfc/ethtool.c b/drivers/net/ethernet/sfc/ethtool.c index 03ded364c8da..10536f93b561 100644 --- a/drivers/net/ethernet/sfc/ethtool.c +++ b/drivers/net/ethernet/sfc/ethtool.c @@ -453,7 +453,7 @@ static void efx_ethtool_get_strings(struct net_device *net_dev, switch (string_set) { case ETH_SS_STATS: for (i = 0; i < EFX_ETHTOOL_NUM_STATS; i++) - strncpy(ethtool_strings[i].name, + strlcpy(ethtool_strings[i].name, efx_ethtool_stats[i].name, sizeof(ethtool_strings[i].name)); break;