From: Dan Carpenter Date: Fri, 18 Jan 2013 07:41:38 +0000 (+0300) Subject: USB: c67x00-ll-hpi.c: signedness bug in ll_recv_msg() X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=a29c408521b2b8969fead6aa3c7819800d6b473a;p=openwrt%2Fstaging%2Fblogic.git USB: c67x00-ll-hpi.c: signedness bug in ll_recv_msg() The callers expect this function to return zero on success or -EIO if it times out. The type should be int instead of unsigned short. Signed-off-by: Dan Carpenter Acked-by: Peter Korsgaard Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/c67x00/c67x00-ll-hpi.c b/drivers/usb/c67x00/c67x00-ll-hpi.c index a9636f43bca2..3a1ca4dfc83a 100644 --- a/drivers/usb/c67x00/c67x00-ll-hpi.c +++ b/drivers/usb/c67x00/c67x00-ll-hpi.c @@ -237,7 +237,7 @@ void c67x00_ll_hpi_disable_sofeop(struct c67x00_sie *sie) /* -------------------------------------------------------------------------- */ /* Transactions */ -static inline u16 ll_recv_msg(struct c67x00_device *dev) +static inline int ll_recv_msg(struct c67x00_device *dev) { u16 res;