From: Heiner Kallweit Date: Mon, 12 Nov 2018 20:16:06 +0000 (+0100) Subject: net: phy: check for implementation of both callbacks in phy_drv_supports_irq X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=a21ff3c83b1a7e110bae208221ef817251ef564c;p=openwrt%2Fstaging%2Fblogic.git net: phy: check for implementation of both callbacks in phy_drv_supports_irq Now that the icplus driver has been fixed all PHY drivers supporting interrupts have both callbacks (config_intr and ack_interrupt) implemented - as it should be. Therefore phy_drv_supports_irq() can be changed now to check for both callbacks being implemented. Signed-off-by: Heiner Kallweit Acked-by: Florian Fainelli Signed-off-by: David S. Miller --- diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 55202a0ac476..e06613f2d431 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -2122,7 +2122,7 @@ static void of_set_phy_eee_broken(struct phy_device *phydev) static bool phy_drv_supports_irq(struct phy_driver *phydrv) { - return phydrv->config_intr || phydrv->ack_interrupt; + return phydrv->config_intr && phydrv->ack_interrupt; } /**