From: Martin Svec <martin.svec@zoner.cz>
Date: Tue, 1 Apr 2014 14:03:02 +0000 (+0200)
Subject: Target/sbc: Initialize COMPARE_AND_WRITE write_sg scatterlist
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=a1e1774c6dfa3a524dd8df51ca95185fe5ef3247;p=openwrt%2Fstaging%2Fblogic.git

Target/sbc: Initialize COMPARE_AND_WRITE write_sg scatterlist

When compiled with CONFIG_DEBUG_SG set, uninitialized SGL leads
to BUG() in compare_and_write_callback().

Signed-off-by: Martin Svec <martin.svec@zoner.cz>
Cc: <stable@vger.kernel.org> #3.12+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
---

diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c
index 62daef5c0c8f..ec204f7ef126 100644
--- a/drivers/target/target_core_sbc.c
+++ b/drivers/target/target_core_sbc.c
@@ -425,13 +425,14 @@ static sense_reason_t compare_and_write_callback(struct se_cmd *cmd)
 		goto out;
 	}
 
-	write_sg = kzalloc(sizeof(struct scatterlist) * cmd->t_data_nents,
+	write_sg = kmalloc(sizeof(struct scatterlist) * cmd->t_data_nents,
 			   GFP_KERNEL);
 	if (!write_sg) {
 		pr_err("Unable to allocate compare_and_write sg\n");
 		ret = TCM_OUT_OF_RESOURCES;
 		goto out;
 	}
+	sg_init_table(write_sg, cmd->t_data_nents);
 	/*
 	 * Setup verify and write data payloads from total NumberLBAs.
 	 */