From: Christian Marangi <ansuelsmth@gmail.com>
Date: Sun, 12 Nov 2023 15:15:07 +0000 (+0100)
Subject: scripts/getver.sh: prevent asking for negative rev-parse
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=9e49e0a6c4535d345084cc62c594be5cad23b911;p=openwrt%2Fstaging%2Fblogic.git

scripts/getver.sh: prevent asking for negative rev-parse

With the case of asking an invalid version that is too big, getver.sh
might return an invalid output in the form of HEAD~-2260475641.

This is caused by BASE_REV - GET_REV using a negative number.

Prevent this by checking if BASE_REV - GET_REV actually return 0 or a
positive number and set REV variable accordingly. With the following
change, invalid revision number will result in unknown printed instead
of the invalid HEAD~-NUMBERS output.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---

diff --git a/scripts/getver.sh b/scripts/getver.sh
index 49260a22603f..61906040b18f 100755
--- a/scripts/getver.sh
+++ b/scripts/getver.sh
@@ -21,7 +21,7 @@ try_git() {
 	r*)
 		GET_REV="$(echo $GET_REV | tr -d 'r')"
 		BASE_REV="$(git rev-list ${REBOOT}..HEAD 2>/dev/null | wc -l | awk '{print $1}')"
-		REV="$(git rev-parse HEAD~$((BASE_REV - GET_REV)))"
+		[ $((BASE_REV - GET_REV)) -ge 0 ] && REV="$(git rev-parse HEAD~$((BASE_REV - GET_REV)))"
 		;;
 	*)
 		BRANCH="$(git rev-parse --abbrev-ref HEAD)"