From: Al Viro Date: Thu, 28 Jul 2011 02:27:33 +0000 (-0400) Subject: devtmpfs: missing initialialization in never-hit case X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=9d108d25487bf958f8093409a4c0bee6169edba6;p=openwrt%2Fstaging%2Fblogic.git devtmpfs: missing initialialization in never-hit case create_path() on something without a single / in it will return err without initializing it. It actually can't happen (we call that thing only if create on the same path returns -ENOENT, which won't happen happen for single-component path), but in this case initializing err to 0 is more than making compiler to STFU - would be the right thing to return on such paths; the function creates a parent directory of given pathname and in that case it has no work to do... Signed-off-by: Al Viro --- diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c index b89fffc1d777..33e1bed68fdd 100644 --- a/drivers/base/devtmpfs.c +++ b/drivers/base/devtmpfs.c @@ -166,7 +166,7 @@ static int create_path(const char *nodepath) { char *path; char *s; - int err; + int err = 0; /* parent directories do not exist, create them */ path = kstrdup(nodepath, GFP_KERNEL);