From: Jan Hoffmann Date: Wed, 6 Dec 2023 01:24:25 +0000 (+0100) Subject: luci-app-vnstat2: fix configuration page when database is empty (#6746) X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=9cd7b55210c767f858da0267807813e9ef19cd3a;p=project%2Fluci.git luci-app-vnstat2: fix configuration page when database is empty (#6746) The output of the command "vnstat --dbiflist 1" is empty when there are no interfaces in the database. Add a check to avoid a "result.stdout is undefined" error in that case. Ref: https://forum.openwrt.org/t/error-in-luci-vnstat2-configuration-menu/179700 Fixes: 3ac4f567dfdf ("luci-app-vnstat2: use more efficient way to get database interfaces") Signed-off-by: Jan Hoffmann (cherry picked from commit c0c37903f2276224c246c2a5ba0fb2732ba0e18a) --- diff --git a/applications/luci-app-vnstat2/htdocs/luci-static/resources/view/vnstat2/config.js b/applications/luci-app-vnstat2/htdocs/luci-static/resources/view/vnstat2/config.js index 4d4bfd0dbe..dd5bf715e4 100644 --- a/applications/luci-app-vnstat2/htdocs/luci-static/resources/view/vnstat2/config.js +++ b/applications/luci-app-vnstat2/htdocs/luci-static/resources/view/vnstat2/config.js @@ -60,7 +60,7 @@ return view.extend({ o.load = function(section_id) { return fs.exec('/usr/bin/vnstat', ['--dbiflist', '1']).then(L.bind(function(result) { var databaseInterfaces = []; - if (result.code == 0) { + if (result.code == 0 && result.stdout) { databaseInterfaces = result.stdout.trim().split('\n'); }