From: Suzuki K Poulose Date: Tue, 10 May 2016 10:14:41 +0000 (+0100) Subject: arm64: secondary_start_kernel: Remove unnecessary barrier X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=99aa036241ed4a08a71b627bb903b5d7c75d78c1;p=openwrt%2Fstaging%2Fblogic.git arm64: secondary_start_kernel: Remove unnecessary barrier Remove the unnecessary smp_wmb(), which was added to make sure that the update_cpu_boot_status() completes before we mark the CPU online. But update_cpu_boot_status() already has dsb() (required for the failing CPUs) to ensure the correct behavior. Cc: Catalin Marinas Acked-by: Mark Rutland Reported-by: Dennis Chen Signed-off-by: Suzuki K Poulose Signed-off-by: Will Deacon --- diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c index dc9647521c59..678e0842cb3b 100644 --- a/arch/arm64/kernel/smp.c +++ b/arch/arm64/kernel/smp.c @@ -264,8 +264,6 @@ asmlinkage void secondary_start_kernel(void) pr_info("CPU%u: Booted secondary processor [%08x]\n", cpu, read_cpuid_id()); update_cpu_boot_status(CPU_BOOT_SUCCESS); - /* Make sure the status update is visible before we complete */ - smp_wmb(); set_cpu_online(cpu, true); complete(&cpu_running);