From: Jesper Juhl Date: Sat, 27 Aug 2011 16:58:34 +0000 (+0200) Subject: CIFS: Don't free volume_info->UNC until we are entirely done with it. X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=95c754545353ca7db2e12485546eac626f8461f9;p=openwrt%2Fstaging%2Fblogic.git CIFS: Don't free volume_info->UNC until we are entirely done with it. In cleanup_volume_info_contents() we kfree(volume_info->UNC); and then proceed to use that variable on the very next line. This causes (at least) Coverity Prevent to complain about use-after-free of that variable (and I guess other checkers may do that as well). There's not any /real/ problem here since we are just using the value of the pointer, not actually dereferencing it, but it's still trivial to silence the tool, so why not? To me at least it also just seems nicer to defer freeing the variable until we are entirely done with it in all respects. Signed-off-by: Jesper Juhl Reviewed-by: Jeff Layton Signed-off-by: Jiri Kosina --- diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 633c246b6775..9bb4b10f0cda 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -2877,9 +2877,9 @@ cleanup_volume_info_contents(struct smb_vol *volume_info) { kfree(volume_info->username); kzfree(volume_info->password); - kfree(volume_info->UNC); if (volume_info->UNCip != volume_info->UNC + 2) kfree(volume_info->UNCip); + kfree(volume_info->UNC); kfree(volume_info->domainname); kfree(volume_info->iocharset); kfree(volume_info->prepath);