From: Felix Fietkau <nbd@openwrt.org>
Date: Thu, 16 Apr 2015 20:09:30 +0000 (+0000)
Subject: base-files: reorder led trigger/brightness writes
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=93fb3cac1b46bd290b3a52c3011d7ffc5d2e524b;p=openwrt%2Fstaging%2Fmans0n.git

base-files: reorder led trigger/brightness writes

Depending on configuration, disable the LED before writing the trigger
and enable it after writing it. Fixes LEDs where the value defaults to 1

Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 45463
---

diff --git a/package/base-files/files/etc/init.d/led b/package/base-files/files/etc/init.d/led
index 6962bfa843..ba4dd6791d 100755
--- a/package/base-files/files/etc/init.d/led
+++ b/package/base-files/files/etc/init.d/led
@@ -34,14 +34,17 @@ load_led() {
 
 	[ -e /sys/class/leds/${sysfs}/brightness ] && {
 		echo "setting up led ${name}"
-		[ "$default" != nil ] && {
-			[ $default -eq 1 ] &&
-				echo 1 >/sys/class/leds/${sysfs}/brightness
-			[ $default -eq 1 ] ||
-				echo 0 >/sys/class/leds/${sysfs}/brightness
-		}
+
+		[ "$default" = 0 ] ||
+			echo 0 >/sys/class/leds/${sysfs}/brightness
+
 		echo $trigger > /sys/class/leds/${sysfs}/trigger 2> /dev/null
-		[ $? = 0 ] || {
+		ret="$?"
+
+		[ $default = 1 ] &&
+			echo 1 >/sys/class/leds/${sysfs}/brightness
+
+		[ $ret = 0 ] || {
 			echo >&2 "Skipping trigger '$trigger' for led '$name' due to missing kernel module"
 			return 1
 		}