From: Linus Walleij Date: Wed, 26 Jun 2019 08:11:17 +0000 (+0200) Subject: gpio: siox: Switch to IRQ_TYPE_NONE X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=8df9d7f70f87960b6ad2b4a90db755551d7ab7bd;p=openwrt%2Fstaging%2Fblogic.git gpio: siox: Switch to IRQ_TYPE_NONE The siox driver is hardcoding a default type of IRQ_TYPE_EDGE_RISING to the irq helper, but this should only be applicable to old boardfiles and odd device tree irqchips with just onecell irq (no flags). I doubt this is the case with the siox, I think all consumers specify the flags they use in the device tree. Acked-by: Uwe Kleine-König Signed-off-by: Linus Walleij --- diff --git a/drivers/gpio/gpio-siox.c b/drivers/gpio/gpio-siox.c index 0b4450118865..40067e1535d3 100644 --- a/drivers/gpio/gpio-siox.c +++ b/drivers/gpio/gpio-siox.c @@ -247,7 +247,7 @@ static int gpio_siox_probe(struct siox_device *sdevice) } ret = gpiochip_irqchip_add(&ddata->gchip, &ddata->ichip, - 0, handle_level_irq, IRQ_TYPE_EDGE_RISING); + 0, handle_level_irq, IRQ_TYPE_NONE); if (ret) dev_err(&sdevice->dev, "Failed to register irq chip (%d)\n", ret);