From: Niklas Söderlund Date: Fri, 14 Dec 2018 06:18:21 +0000 (-0200) Subject: media: rcar-vin: fix wrong return value in rvin_set_channel_routing() X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=8d19d5d03b4d09177b0ae87f964eb751e6f51b7b;p=openwrt%2Fstaging%2Fblogic.git media: rcar-vin: fix wrong return value in rvin_set_channel_routing() If the operation in rvin_set_channel_routing() is successful the 'ret' variable contains the runtime PM use count for the VIN master device. The intention is not to return the use count to the caller but to return 0 on success else none zero. Fix this by always returning 0 if the operation is successful. Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c b/drivers/media/platform/rcar-vin/rcar-dma.c index 92323310f735..beb9248992a4 100644 --- a/drivers/media/platform/rcar-vin/rcar-dma.c +++ b/drivers/media/platform/rcar-vin/rcar-dma.c @@ -1341,5 +1341,5 @@ int rvin_set_channel_routing(struct rvin_dev *vin, u8 chsel) pm_runtime_put(vin->dev); - return ret; + return 0; }