From: Ian Abbott Date: Tue, 19 Jun 2012 09:17:43 +0000 (+0100) Subject: staging: comedi: make class and file operations static X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=8cb8aad7d34cdc82fe205905c8dff771efb9604d;p=openwrt%2Fstaging%2Fblogic.git staging: comedi: make class and file operations static A couple of global variables in "comedi_fops.c" are only referenced from that .c file and can be declared 'static'. Also remove them from "comedi_fops.h" where they are declared 'extern'. Signed-off-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index ad8634734194..3650753b62f7 100644 --- a/drivers/staging/comedi/comedi_fops.c +++ b/drivers/staging/comedi/comedi_fops.c @@ -2182,7 +2182,7 @@ static int comedi_fasync(int fd, struct file *file, int on) return fasync_helper(fd, file, on, &dev->async_queue); } -const struct file_operations comedi_fops = { +static const struct file_operations comedi_fops = { .owner = THIS_MODULE, .unlocked_ioctl = comedi_unlocked_ioctl, .compat_ioctl = comedi_compat_ioctl, @@ -2196,7 +2196,7 @@ const struct file_operations comedi_fops = { .llseek = noop_llseek, }; -struct class *comedi_class; +static struct class *comedi_class; static struct cdev comedi_cdev; static void comedi_cleanup_legacy_minors(void) diff --git a/drivers/staging/comedi/comedi_fops.h b/drivers/staging/comedi/comedi_fops.h index 006cf14c577a..d59a29300f31 100644 --- a/drivers/staging/comedi/comedi_fops.h +++ b/drivers/staging/comedi/comedi_fops.h @@ -3,8 +3,6 @@ #define _COMEDI_FOPS_H #include -extern struct class *comedi_class; -extern const struct file_operations comedi_fops; extern bool comedi_autoconfig; extern struct comedi_driver *comedi_drivers;