From: Ezequiel GarcĂ­a Date: Thu, 23 Aug 2012 12:08:28 +0000 (-0300) Subject: [media] mem2mem-emmaprp: Remove unneeded struct vb2_queue clear on queue_init() X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=8c6f59f9795e03f4bec3f176df26bd1ff755afa1;p=openwrt%2Fstaging%2Fblogic.git [media] mem2mem-emmaprp: Remove unneeded struct vb2_queue clear on queue_init() queue_init() is always called by v4l2_m2m_ctx_init(), which allocates a context struct v4l2_m2m_ctx with kzalloc. Therefore, there is no need to clear vb2_queue src/dst structs. Signed-off-by: Ezequiel Garcia Acked-by: Javier Martin Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/mx2_emmaprp.c b/drivers/media/platform/mx2_emmaprp.c index dab380a8d1c6..59aaca4de183 100644 --- a/drivers/media/platform/mx2_emmaprp.c +++ b/drivers/media/platform/mx2_emmaprp.c @@ -757,7 +757,6 @@ static int queue_init(void *priv, struct vb2_queue *src_vq, struct emmaprp_ctx *ctx = priv; int ret; - memset(src_vq, 0, sizeof(*src_vq)); src_vq->type = V4L2_BUF_TYPE_VIDEO_OUTPUT; src_vq->io_modes = VB2_MMAP | VB2_USERPTR; src_vq->drv_priv = ctx; @@ -769,7 +768,6 @@ static int queue_init(void *priv, struct vb2_queue *src_vq, if (ret) return ret; - memset(dst_vq, 0, sizeof(*dst_vq)); dst_vq->type = V4L2_BUF_TYPE_VIDEO_CAPTURE; dst_vq->io_modes = VB2_MMAP | VB2_USERPTR; dst_vq->drv_priv = ctx;