From: Ivan Safonov Date: Thu, 11 Feb 2016 18:25:30 +0000 (+0700) Subject: staging: rtl8188eu: add release_firmware() between request_firmware and function... X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=8b0187188a423daa741cc544205c224c1ff84c33;p=openwrt%2Fstaging%2Fblogic.git staging: rtl8188eu: add release_firmware() between request_firmware and function error exit Small memory leak fixed. Signed-off-by: Ivan Safonov Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index 55c17df0e839..656133c47426 100644 --- a/drivers/staging/rtl8188eu/hal/fw.c +++ b/drivers/staging/rtl8188eu/hal/fw.c @@ -175,14 +175,17 @@ int rtl88eu_download_fw(struct adapter *adapt) if (fw->size > FW_8188E_SIZE) { dev_err(device, "Firmware size exceed 0x%X. Check it.\n", FW_8188E_SIZE); + release_firmware(fw); return -1; } trailing_zeros_length = (4 - fw->size % 4) % 4; fw_data = kmalloc(fw->size + trailing_zeros_length, GFP_KERNEL); - if (!fw_data) + if (!fw_data) { + release_firmware(fw); return -ENOMEM; + } memcpy(fw_data, fw->data, fw->size); memset(fw_data + fw->size, 0, trailing_zeros_length);