From: Dominic Braun Date: Fri, 14 Dec 2018 12:04:59 +0000 (+0100) Subject: staging: vc04_services: Remove VCHIQ_QUEUE_MESSAGE_T typedef X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=87c091aadfacbf8c2d7d5329f923c7bbd46c840a;p=openwrt%2Fstaging%2Fblogic.git staging: vc04_services: Remove VCHIQ_QUEUE_MESSAGE_T typedef Typedefing structs is not encouraged in the kernel. Signed-off-by: Dominic Braun Signed-off-by: Tobias Büttner Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index f2c871f8c0ff..13985501a8c0 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -1040,7 +1040,7 @@ vchiq_ioctl(struct file *file, unsigned int cmd, unsigned long arg) } break; case VCHIQ_IOC_QUEUE_MESSAGE: { - VCHIQ_QUEUE_MESSAGE_T args; + struct vchiq_queue_message args; if (copy_from_user (&args, (const void __user *)arg, @@ -1593,7 +1593,7 @@ vchiq_compat_ioctl_queue_message(struct file *file, unsigned int cmd, unsigned long arg) { - VCHIQ_QUEUE_MESSAGE_T *args; + struct vchiq_queue_message *args; struct vchiq_element __user *elements; struct vchiq_queue_message32 args32; unsigned int count; diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h index 284ce4faa384..9e21d1c472de 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h @@ -47,11 +47,11 @@ struct vchiq_create_service { unsigned int handle; /* OUT */ }; -typedef struct { +struct vchiq_queue_message { unsigned int handle; unsigned int count; const struct vchiq_element __user *elements; -} VCHIQ_QUEUE_MESSAGE_T; +}; struct vchiq_queue_bulk_transfer { unsigned int handle; @@ -105,7 +105,7 @@ struct vchiq_dump_mem { _IOWR(VCHIQ_IOC_MAGIC, 2, struct vchiq_create_service) #define VCHIQ_IOC_REMOVE_SERVICE _IO(VCHIQ_IOC_MAGIC, 3) #define VCHIQ_IOC_QUEUE_MESSAGE \ - _IOW(VCHIQ_IOC_MAGIC, 4, VCHIQ_QUEUE_MESSAGE_T) + _IOW(VCHIQ_IOC_MAGIC, 4, struct vchiq_queue_message) #define VCHIQ_IOC_QUEUE_BULK_TRANSMIT \ _IOWR(VCHIQ_IOC_MAGIC, 5, struct vchiq_queue_bulk_transfer) #define VCHIQ_IOC_QUEUE_BULK_RECEIVE \