From: Rafał Mikrut Date: Tue, 8 Dec 2020 20:54:40 +0000 (+0100) Subject: realtek: Fix self assignment X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=848d668427c544d20f8aa3041fa11b4d4adc9bc8;p=openwrt%2Fstaging%2Fldir.git realtek: Fix self assignment Cppcheck shows self initialization error, which is an obvious bug. Basing on logic of similar fragment below I assigned to this variable, value `RTL838X_LED_GLB_CTRL` which I think is proper. Signed-off-by: Rafał Mikrut --- diff --git a/target/linux/realtek/files-5.4/drivers/gpio/gpio-rtl838x.c b/target/linux/realtek/files-5.4/drivers/gpio/gpio-rtl838x.c index 92cf5f765a..8207e4bb73 100644 --- a/target/linux/realtek/files-5.4/drivers/gpio/gpio-rtl838x.c +++ b/target/linux/realtek/files-5.4/drivers/gpio/gpio-rtl838x.c @@ -357,7 +357,7 @@ static int rtl838x_gpio_probe(struct platform_device *pdev) } if (soc_info.family == RTL8380_FAMILY_ID) { - gpios->led_glb_ctrl = gpios->led_glb_ctrl; + gpios->led_glb_ctrl = RTL838X_LED_GLB_CTRL; gpios->led_sw_ctrl = RTL838X_LED_SW_CTRL; gpios->led_sw_p_ctrl = rtl838x_led_sw_p_ctrl; gpios->led_sw_p_en_ctrl = rtl838x_led_sw_p_en_ctrl;