From: Xiongfeng Wang Date: Mon, 8 Jan 2018 12:40:59 +0000 (-0500) Subject: media: media-device: use strlcpy() instead of strncpy() X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=81b9de43599c59a3d5bd3e6e8645cb20b87840bc;p=openwrt%2Fstaging%2Fblogic.git media: media-device: use strlcpy() instead of strncpy() gcc-8 reports drivers/media/media-device.c: In function 'media_device_get_topology': ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified bound 64 equals destination size [-Wstringop-truncation] We need to use strlcpy() to make sure the dest string is nul-terminated. Signed-off-by: Xiongfeng Wang Acked-by: Sakari Ailus Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c index e79f72b8b858..f44244415124 100644 --- a/drivers/media/media-device.c +++ b/drivers/media/media-device.c @@ -255,7 +255,7 @@ static long media_device_get_topology(struct media_device *mdev, memset(&kentity, 0, sizeof(kentity)); kentity.id = entity->graph_obj.id; kentity.function = entity->function; - strncpy(kentity.name, entity->name, + strlcpy(kentity.name, entity->name, sizeof(kentity.name)); if (copy_to_user(uentity, &kentity, sizeof(kentity)))