From: K. Y. Srinivasan Date: Thu, 29 Sep 2011 18:54:43 +0000 (-0700) Subject: Staging: hv: mousevsc: Fixup some bogus WARN_ON() calls X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=7f2bad4bd0d22f4cdd876152f1eeb9a8cfdc8d9d;p=openwrt%2Fstaging%2Fblogic.git Staging: hv: mousevsc: Fixup some bogus WARN_ON() calls Fix the bogus WARN_ON() calls. Signed-off-by: K. Y. Srinivasan Signed-off-by: Haiyang Zhang Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c index 69eb00e45f8b..016d7e570d1c 100644 --- a/drivers/staging/hv/hv_mouse.c +++ b/drivers/staging/hv/hv_mouse.c @@ -200,7 +200,7 @@ static struct mousevsc_dev *alloc_input_device(struct hv_device *device) static void free_input_device(struct mousevsc_dev *device) { - WARN_ON(atomic_read(&device->ref_count) == 0); + WARN_ON(atomic_read(&device->ref_count) != 0); kfree(device); } @@ -327,7 +327,7 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device, /* Save the hid desc */ desc = &device_info->hid_descriptor; - WARN_ON(desc->bLength > 0); + WARN_ON(desc->bLength == 0); input_device->hid_desc = kzalloc(desc->bLength, GFP_KERNEL); @@ -447,7 +447,7 @@ static void mousevsc_on_receive(struct hv_device *device, break; case SynthHidInitialDeviceInfo: - WARN_ON(pipe_msg->size >= sizeof(struct hv_input_dev_info)); + WARN_ON(pipe_msg->size < sizeof(struct hv_input_dev_info)); /* * Parse out the device info into device attr,