From: Florian Fainelli Date: Sat, 18 Feb 2017 00:07:33 +0000 (-0800) Subject: net: phy: Fix PHY unbind crash X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=7b9a88a390dacb37b051a7b09b9a08f546edf5eb;p=openwrt%2Fstaging%2Fblogic.git net: phy: Fix PHY unbind crash The PHY library does not deal very well with bind and unbind events. The first thing we would see is that we were not properly canceling the PHY state machine workqueue, so we would be crashing while dereferencing phydev->drv since there is no driver attached anymore. Suggested-by: Russell King Signed-off-by: Florian Fainelli Signed-off-by: David S. Miller --- diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 8c8e15b8739d..7f9319586b7e 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -1784,6 +1784,8 @@ static int phy_remove(struct device *dev) { struct phy_device *phydev = to_phy_device(dev); + cancel_delayed_work_sync(&phydev->state_queue); + mutex_lock(&phydev->lock); phydev->state = PHY_DOWN; mutex_unlock(&phydev->lock);