From: Gabor Juhos Date: Tue, 8 Jun 2010 20:18:05 +0000 (+0000) Subject: ip17xx: Fixed error handling in ip175c_set_val() X-Git-Tag: reboot~19701 X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=7b5a77fa391c20e3954aa358d8edbfacefbcff9e;p=openwrt%2Fstaging%2Fblogic.git ip17xx: Fixed error handling in ip175c_set_val() Upon error, ip175c_set_val() returned 0 instead of -EINVAL. Signed-off-by: Martin Mares Signed-off-by: Patrick Horn SVN-Revision: 21711 --- diff --git a/target/linux/generic-2.6/files/drivers/net/phy/ip175c.c b/target/linux/generic-2.6/files/drivers/net/phy/ip175c.c index 00144e886427..8e1afcd7c231 100644 --- a/target/linux/generic-2.6/files/drivers/net/phy/ip175c.c +++ b/target/linux/generic-2.6/files/drivers/net/phy/ip175c.c @@ -947,7 +947,7 @@ static int ip175c_get_val(struct switch_dev *dev, const struct switch_attr *attr static int ip175c_set_val(struct switch_dev *dev, const struct switch_attr *attr, struct switch_val *val) { struct ip175c_state *state = dev->priv; - int myval, err = 0; + int myval, err = -EINVAL; myval = val->value.i; if (myval <= 0xffff && myval >= 0 && REG_SUPP(state->proc_mii)) {