From: Andy Shevchenko Date: Fri, 14 Feb 2020 11:43:32 +0000 (+0200) Subject: serial: core: Introduce uart_console_enabled() helper X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=7a49955af1441dd58d27c1ab59205d83ec42907f;p=openwrt%2Fstaging%2Fblogic.git serial: core: Introduce uart_console_enabled() helper Introduce uart_console_enabled() helper which checks port to be console and console is registered in the list. Note, this helper will be used in the future as well. Signed-off-by: Andy Shevchenko Link: https://lore.kernel.org/r/20200214114339.53897-2-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c index 76e506ee335c..d956da0b6d9c 100644 --- a/drivers/tty/serial/serial_core.c +++ b/drivers/tty/serial/serial_core.c @@ -1908,6 +1908,11 @@ static int uart_proc_show(struct seq_file *m, void *v) } #endif +static inline bool uart_console_enabled(struct uart_port *port) +{ + return uart_console(port) && (port->cons->flags & CON_ENABLED); +} + #if defined(CONFIG_SERIAL_CORE_CONSOLE) || defined(CONFIG_CONSOLE_POLL) /** * uart_console_write - write a console message to a serial port @@ -2066,7 +2071,7 @@ uart_set_options(struct uart_port *port, struct console *co, * If this port is a console, then the spinlock is already * initialised. */ - if (!(uart_console(port) && (port->cons->flags & CON_ENABLED))) { + if (!uart_console_enabled(port)) { spin_lock_init(&port->lock); lockdep_set_class(&port->lock, &port_lock_key); } @@ -2828,7 +2833,7 @@ int uart_add_one_port(struct uart_driver *drv, struct uart_port *uport) * If this port is a console, then the spinlock is already * initialised. */ - if (!(uart_console(uport) && (uport->cons->flags & CON_ENABLED))) { + if (!uart_console_enabled(uport)) { spin_lock_init(&uport->lock); lockdep_set_class(&uport->lock, &port_lock_key); }