From: Paul Donald <newtwen+github@gmail.com>
Date: Mon, 8 Jul 2024 14:34:31 +0000 (+0200)
Subject: luci-mod-status: log viewers - change focus() to scrollIntoView()
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=7893f2d08aaa1a0419ede1a695a25781f60e6ba6;p=project%2Fluci.git

luci-mod-status: log viewers - change focus() to scrollIntoView()

scrollIntoView() is more universally supported and standards tracked.

Closes #7186

Updates 9370bdddaede2feeb581193158d83f5062d5a318

Signed-off-by: Paul Donald <newtwen+github@gmail.com>
---

diff --git a/modules/luci-mod-status/htdocs/luci-static/resources/view/status/dmesg.js b/modules/luci-mod-status/htdocs/luci-static/resources/view/status/dmesg.js
index 45b483962d..aad0383646 100644
--- a/modules/luci-mod-status/htdocs/luci-static/resources/view/status/dmesg.js
+++ b/modules/luci-mod-status/htdocs/luci-static/resources/view/status/dmesg.js
@@ -38,7 +38,7 @@ return view.extend({
 			}, _('Scroll to tail', 'scroll to bottom (the tail) of the log file')
 		);
 		scrollDownButton.addEventListener('click', function() {
-			scrollUpButton.focus();
+			scrollUpButton.scrollIntoView();
 		});
 
 		var scrollUpButton = E('button', { 
@@ -47,7 +47,7 @@ return view.extend({
 			}, _('Scroll to head', 'scroll to top (the head) of the log file')
 		);
 		scrollUpButton.addEventListener('click', function() {
-			scrollDownButton.focus();
+			scrollDownButton.scrollIntoView();
 		});
 
 		return E([], [
diff --git a/modules/luci-mod-status/htdocs/luci-static/resources/view/status/syslog.js b/modules/luci-mod-status/htdocs/luci-static/resources/view/status/syslog.js
index 2e3d705c22..2aa3c46093 100644
--- a/modules/luci-mod-status/htdocs/luci-static/resources/view/status/syslog.js
+++ b/modules/luci-mod-status/htdocs/luci-static/resources/view/status/syslog.js
@@ -43,7 +43,7 @@ return view.extend({
 			}, _('Scroll to tail', 'scroll to bottom (the tail) of the log file')
 		);
 		scrollDownButton.addEventListener('click', function() {
-			scrollUpButton.focus();
+			scrollUpButton.scrollIntoView();
 		});
 
 		var scrollUpButton = E('button', { 
@@ -52,7 +52,7 @@ return view.extend({
 			}, _('Scroll to head', 'scroll to top (the head) of the log file')
 		);
 		scrollUpButton.addEventListener('click', function() {
-			scrollDownButton.focus();
+			scrollDownButton.scrollIntoView();
 		});
 
 		return E([], [