From: Bjørn Mork Date: Sat, 13 Mar 2021 16:45:50 +0000 (+0100) Subject: realtek: need to handle PHY_INTERFACE_MODE_NA for sfps X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=785d830e889ba18793acf369e447d704269169af;p=openwrt%2Fstaging%2Fneocturne.git realtek: need to handle PHY_INTERFACE_MODE_NA for sfps From the validate docs in include/linux/phylink.h: When state->interface is PHY_INTERFACE_MODE_NA, phylink expects the MAC driver to return all supported link modes. Tested-by: Birger Koblitz Signed-off-by: Bjørn Mork --- diff --git a/target/linux/realtek/files-5.4/drivers/net/dsa/rtl83xx/dsa.c b/target/linux/realtek/files-5.4/drivers/net/dsa/rtl83xx/dsa.c index af6d92cbc2..2c49ea27a1 100644 --- a/target/linux/realtek/files-5.4/drivers/net/dsa/rtl83xx/dsa.c +++ b/target/linux/realtek/files-5.4/drivers/net/dsa/rtl83xx/dsa.c @@ -245,6 +245,7 @@ static void rtl83xx_phylink_validate(struct dsa_switch *ds, int port, pr_debug("In %s port %d", __func__, port); if (!phy_interface_mode_is_rgmii(state->interface) && + state->interface != PHY_INTERFACE_MODE_NA && state->interface != PHY_INTERFACE_MODE_1000BASEX && state->interface != PHY_INTERFACE_MODE_MII && state->interface != PHY_INTERFACE_MODE_REVMII &&