From: Daniel Nilsson <dannil+github@protonmail.com>
Date: Wed, 18 Sep 2024 19:37:16 +0000 (+0200)
Subject: luci-app-commands: correctly pass custom arguments as query string
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=72255eb46c9425fbcb3ab4e000032f6b2a0cef2d;p=project%2Fluci.git

luci-app-commands: correctly pass custom arguments as query string

Commit 702c007 changed the request to be invoked via the Request.get function
instead of the deprecated XHR one. The request options object requires the
query string to be located inside of the subobject "query", otherwise they are
not picked up. This resulted in breaking the custom arguments functionality as
the input would simply be ignored.

Fixes #7255

Signed-off-by: Daniel Nilsson <dannil+github@protonmail.com>
---

diff --git a/applications/luci-app-commands/ucode/template/commands.ut b/applications/luci-app-commands/ucode/template/commands.ut
index 90a3c298f0..18e3a9dfda 100644
--- a/applications/luci-app-commands/ucode/template/commands.ut
+++ b/applications/luci-app-commands/ucode/template/commands.ut
@@ -45,7 +45,8 @@
 			legend.parentNode.style.display = 'block';
 			legend.style.display = 'inline';
 
-			L.Request.get(L.url('admin/system/commands/run', id), field ? { args: field.value } : null).then(function(reply) {
+			var options = field ? { query: { args: field.value } } : null;
+			L.Request.get(L.url('admin/system/commands/run', id), options).then(function(reply) {
 				var st = reply.json();
 
 				if (st.binary)