From: Jo-Philipp Wich <jo@mein.io>
Date: Thu, 23 Dec 2021 16:09:13 +0000 (+0100)
Subject: luci.js: remove unsafe fallback code from dom.parse()
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=6f349c9142e436d6c7447c0a2ab108803ba431f8;p=project%2Fluci.git

luci.js: remove unsafe fallback code from dom.parse()

Do not fallback to .innerHTML if DOMParser() failed for whatever reason.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 63d9bcb6825fac92fd7dfa4ba858c8d5aafa23e8)
---

diff --git a/modules/luci-base/htdocs/luci-static/resources/luci.js b/modules/luci-base/htdocs/luci-static/resources/luci.js
index c0e8b15a56..8f8b9673d6 100644
--- a/modules/luci-base/htdocs/luci-static/resources/luci.js
+++ b/modules/luci-base/htdocs/luci-static/resources/luci.js
@@ -1247,7 +1247,7 @@
 		 * `null` on parsing failures or if no element could be found.
 		 */
 		parse: function(s) {
-			var elem;
+			var elem = null;
 
 			try {
 				domParser = domParser || new DOMParser();
@@ -1255,16 +1255,7 @@
 			}
 			catch(e) {}
 
-			if (!elem) {
-				try {
-					dummyElem = dummyElem || document.createElement('div');
-					dummyElem.innerHTML = s;
-					elem = dummyElem.firstChild;
-				}
-				catch (e) {}
-			}
-
-			return elem || null;
+			return elem;
 		},
 
 		/**