From: Chad Dupuis <cdupuis@marvell.com>
Date: Tue, 26 Mar 2019 07:38:48 +0000 (-0700)
Subject: scsi: qedf: Add missing return in qedf_scsi_done()
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=6f15d0c02950c75f85542031ccbf6a9725ca9925;p=openwrt%2Fstaging%2Fblogic.git

scsi: qedf: Add missing return in qedf_scsi_done()

On completions where we do not have a bad scsi_cmnd pointer we should
return before the the label lest we do a double kref_put.

Signed-off-by: Chad Dupuis <cdupuis@marvell.com>
Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
---

diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c
index 8d09cf3fe49b..57c3aa4fb708 100644
--- a/drivers/scsi/qedf/qedf_io.c
+++ b/drivers/scsi/qedf/qedf_io.c
@@ -1392,6 +1392,7 @@ void qedf_scsi_done(struct qedf_ctx *qedf, struct qedf_ioreq *io_req,
 	sc_cmd->SCp.ptr = NULL;
 	sc_cmd->scsi_done(sc_cmd);
 	kref_put(&io_req->refcount, qedf_release_cmd);
+	return;
 
 bad_scsi_ptr:
 	/*