From: Martin Schiller <ms@dev.tdt.de>
Date: Fri, 7 Feb 2020 11:41:59 +0000 (+0100)
Subject: umbim: explicitly check for PIN1 state
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=6d1cca7e659a040f4db2ed042ab71eef66bb03d4;p=openwrt%2Fstaging%2Frmilecki.git

umbim: explicitly check for PIN1 state

PIN2 is used only to restrict changing of fixed dialling feature,
does not affect network registration. Therefore explicitly check for
PIN1 state during connection setup, which is required for network
registration.

Signed-off-by: Martin Schiller <ms@dev.tdt.de>
[Updated commit description]
Signed-off-by: Lech Perczak <lech.perczak@gmail.com>
---

diff --git a/package/network/utils/umbim/files/lib/netifd/proto/mbim.sh b/package/network/utils/umbim/files/lib/netifd/proto/mbim.sh
index db716c3dbf0..a33759cd6d9 100755
--- a/package/network/utils/umbim/files/lib/netifd/proto/mbim.sh
+++ b/package/network/utils/umbim/files/lib/netifd/proto/mbim.sh
@@ -86,7 +86,8 @@ _proto_mbim_setup() {
 	tid=$((tid + 1))
 
 	echo "mbim[$$]" "Checking pin"
-	umbim $DBG -n -t $tid -d $device pinstate || {
+	umbim $DBG -n -t $tid -d $device pinstate
+	[ $? -eq 2 ] && {
 		echo "mbim[$$]" "PIN required"
 		tid=$((tid + 1))
 		umbim $DBG -t $tid -d "$device" disconnect