From: Steven Rostedt (VMware) <rostedt@goodmis.org>
Date: Mon, 14 Jan 2019 21:37:53 +0000 (-0500)
Subject: tracing: Add comment to predicate_parse() about "&&" or "||"
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=6c6dbce196c201810348b6cef6fc5ec77d4d0973;p=openwrt%2Fstaging%2Fblogic.git

tracing: Add comment to predicate_parse() about "&&" or "||"

As the predicat_parse() code is rather complex, commenting subtleties is
important. The switch case statement should be commented to describe that it
is only looking for two '&' or '|' together, which is why the fall through
to an error is after the check.

Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---

diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
index eb694756c4bb..f052ecb085e9 100644
--- a/kernel/trace/trace_events_filter.c
+++ b/kernel/trace/trace_events_filter.c
@@ -491,6 +491,7 @@ predicate_parse(const char *str, int nr_parens, int nr_preds,
 				break;
 			case '&':
 			case '|':
+				/* accepting only "&&" or "||" */
 				if (next[1] == next[0]) {
 					ptr++;
 					break;