From: Chuhong Yuan Date: Sat, 9 Nov 2019 07:55:17 +0000 (+0800) Subject: spi: nxp-fspi: Use devm API to fix missed unregistration of controller X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=69c23dbf5f695c219008257b3bd86cff63edbe0b;p=openwrt%2Fstaging%2Fblogic.git spi: nxp-fspi: Use devm API to fix missed unregistration of controller This driver forgets to unregister controller when remove. Use devm API to unregister it automatically to fix it. Signed-off-by: Chuhong Yuan Link: https://lore.kernel.org/r/20191109075517.29988-1-hslester96@gmail.com Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c index 501b923f2c27..c36bb1bb464e 100644 --- a/drivers/spi/spi-nxp-fspi.c +++ b/drivers/spi/spi-nxp-fspi.c @@ -1027,7 +1027,7 @@ static int nxp_fspi_probe(struct platform_device *pdev) ctlr->dev.of_node = np; - ret = spi_register_controller(ctlr); + ret = devm_spi_register_controller(&pdev->dev, ctlr); if (ret) goto err_destroy_mutex;