From: Sander Vanheule Date: Wed, 1 Jan 2025 19:05:20 +0000 (+0100) Subject: realtek: debounce reset key for Zyxel GS1900 X-Git-Tag: v24.10.0-rc6~50 X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=68bf4844a1cbc9f404f6e93b70a2657e74f1dce9;p=openwrt%2Fopenwrt.git realtek: debounce reset key for Zyxel GS1900 When the reset button is next to the SFP cages, I2C operations on the modules might cause interference on the button's GPIO line. Add a debounce-interval of 5 times the poll-interval to ensure the line is actually stable for some time and not just glitching. This squashes commit 4357f32d41eb ("realtek: debounce reset key for Zyxel GS1900") and commit 777c6106ed4e ("realtek: move debounce-interval to correct node"). Signed-off-by: Sander Vanheule --- diff --git a/target/linux/realtek/dts/rtl8380_zyxel_gs1900.dtsi b/target/linux/realtek/dts/rtl8380_zyxel_gs1900.dtsi index b985c4bc8e..3889fe8859 100644 --- a/target/linux/realtek/dts/rtl8380_zyxel_gs1900.dtsi +++ b/target/linux/realtek/dts/rtl8380_zyxel_gs1900.dtsi @@ -26,6 +26,7 @@ label = "reset"; gpios = <&gpio1 3 GPIO_ACTIVE_LOW>; linux,code = ; + debounce-interval = <100>; }; }; diff --git a/target/linux/realtek/dts/rtl8393_zyxel_gs1900-48.dts b/target/linux/realtek/dts/rtl8393_zyxel_gs1900-48.dts index 9844dc2180..a1e0a6d06d 100644 --- a/target/linux/realtek/dts/rtl8393_zyxel_gs1900-48.dts +++ b/target/linux/realtek/dts/rtl8393_zyxel_gs1900-48.dts @@ -43,10 +43,11 @@ compatible = "gpio-keys-polled"; poll-interval = <20>; - mode { + reset { label = "reset"; gpios = <&gpio1 3 GPIO_ACTIVE_LOW>; linux,code = ; + debounce-interval = <100>; }; };