From: Takashi Iwai Date: Wed, 19 Dec 2012 16:41:52 +0000 (+0100) Subject: ALSA: hda - Use "Capture Source" for single sources X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=624d914d091a5eebb4d648bd6b4ae6481171ae5c;p=openwrt%2Fstaging%2Fblogic.git ALSA: hda - Use "Capture Source" for single sources In general we prefer "Capture Source" to "Input Source". The latter was chosen in many places just because "Capture Source" label doesn't work well with the current alsa-lib mixer abstraction when multiple instances are present. But when we know that there is a single input-source element, we can safely choose "Capture Source" label. Signed-off-by: Takashi Iwai --- diff --git a/sound/pci/hda/hda_generic.c b/sound/pci/hda/hda_generic.c index 6914d70df09a..f8d1d03cd219 100644 --- a/sound/pci/hda/hda_generic.c +++ b/sound/pci/hda/hda_generic.c @@ -2172,7 +2172,9 @@ static int create_capture_mixers(struct hda_codec *codec) if (!spec->auto_mic && imux->num_items > 1) { struct snd_kcontrol_new *knew; - knew = snd_hda_gen_add_kctl(spec, NULL, &cap_src_temp); + const char *name; + name = nums > 1 ? "Input Source" : "Capture Source"; + knew = snd_hda_gen_add_kctl(spec, name, &cap_src_temp); if (!knew) return -ENOMEM; knew->count = nums;