From: Stefan Richter <stefanr@s5r6.in-berlin.de>
Date: Tue, 17 Jul 2007 00:13:48 +0000 (+0200)
Subject: firewire: remove bogus check in fw_core_handle_request
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=5d59a6f1ba90f15132d55d9d4d5a632f15a43d84;p=openwrt%2Fstaging%2Fblogic.git

firewire: remove bogus check in fw_core_handle_request

This check is bogus:
  - Maximum asynchronous payload size for S800...S3200 is 4096.
  - The p->payload_length is totally uninteresting.  Only the
    request->length of the subsequently allocated and initialized
    struct fw_request is of significance.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Kristian Høgsberg <krh@redhat.com>
---

diff --git a/drivers/firewire/fw-transaction.c b/drivers/firewire/fw-transaction.c
index 80d0121463d0..c4b3417a5dac 100644
--- a/drivers/firewire/fw-transaction.c
+++ b/drivers/firewire/fw-transaction.c
@@ -628,11 +628,6 @@ fw_core_handle_request(struct fw_card *card, struct fw_packet *p)
 	unsigned long flags;
 	int tcode, destination, source;
 
-	if (p->payload_length > 2048) {
-		/* FIXME: send error response. */
-		return;
-	}
-
 	if (p->ack != ACK_PENDING && p->ack != ACK_COMPLETE)
 		return;