From: Amitoj Kaur Chawla Date: Thu, 2 Apr 2015 17:31:04 +0000 (+0530) Subject: Staging: sm750fb: Remove zero testing pointer typed value X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=59f084070c96f777f977ebd58dc934b9d2a1d95b;p=openwrt%2Fstaging%2Fblogic.git Staging: sm750fb: Remove zero testing pointer typed value Removes variable comparison with 0. Done using following coccinelle script. @ disable is_zero,isnt_zero @ expression *E; expression E1,f; @@ E = f(...) <... ( - E == 0 + !E | - E != 0 + E | - 0 == E + !E | - 0 != E + E ) ...> ?E = E1 @ disable is_zero,isnt_zero @ expression *E; @@ ( E == - 0 + NULL | E != - 0 + NULL | - 0 + NULL == E | - 0 + NULL != E ) Signed-off-by: Amitoj Kaur Chawla Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c index cd1508a35fc2..9b5bb7eba279 100644 --- a/drivers/staging/sm750fb/ddk750_chip.c +++ b/drivers/staging/sm750fb/ddk750_chip.c @@ -110,7 +110,7 @@ void setChipClock(unsigned int frequency) return; #endif - if (frequency != 0) { + if (frequency) { /* * Set up PLL, a structure to hold the value to be set in clocks. */ @@ -139,7 +139,7 @@ void setMemoryClock(unsigned int frequency) if (getChipType() == SM750LE) return; #endif - if (frequency != 0) { + if (frequency) { /* Set the frequency to the maximum frequency that the DDR Memory can take which is 336MHz. */ if (frequency > MHz(336)) @@ -187,7 +187,7 @@ void setMasterClock(unsigned int frequency) if (getChipType() == SM750LE) return; #endif - if (frequency != 0) { + if (frequency) { /* Set the frequency to the maximum frequency that the SM750 engine can run, which is about 190 MHz. */ if (frequency > MHz(190))