From: Bhanusree Pola Date: Thu, 21 Mar 2019 09:35:27 +0000 (+0530) Subject: Staging: media: Use !x in place of NULL comparision X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=53db33a489349128a2a430f8f0e924417c4c31c8;p=openwrt%2Fstaging%2Fblogic.git Staging: media: Use !x in place of NULL comparision Test for NULL as !x instead of NULL comparisions for functions that return NULL on failure. Issue found using coccinelle Semantic patch used to solve the problem is as follows // @@ expression x; statement S; @@ x = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\| usb_alloc_urb\|alloc_netdev\|dev_alloc_skb\)(...)); -if(x==NULL) +if(!x) // Signed-off-by: Bhanusree Pola Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/media/zoran/zoran_driver.c b/drivers/staging/media/zoran/zoran_driver.c index 04f88f9d6bb4..0a99e16e5bd5 100644 --- a/drivers/staging/media/zoran/zoran_driver.c +++ b/drivers/staging/media/zoran/zoran_driver.c @@ -332,7 +332,7 @@ static int jpg_fbuffer_alloc(struct zoran_fh *fh) if (fh->buffers.need_contiguous) { mem = kmalloc(fh->buffers.buffer_size, GFP_KERNEL); - if (mem == NULL) { + if (!mem) { dprintk(1, KERN_ERR "%s: %s - kmalloc failed for buffer %d\n",